Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changes needed for ci.common varProcessing #1843

Merged
merged 6 commits into from
Nov 13, 2024
Merged

changes needed for ci.common varProcessing #1843

merged 6 commits into from
Nov 13, 2024

Conversation

arunvenmany-ibm
Copy link
Contributor

No description provided.

cherylking
cherylking reviewed Nov 12, 2024
View reviewed changes
Copy link
Member

@cherylking cherylking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. But I will hold off on approval until the common PR is merged and the changes to yaml file are removed.

@cherylking cherylking changed the title workflow yaml changes to test ci comon varProcessing branch with ci.maven integration tests changes needed for ci.common varProcessing Nov 13, 2024
@cherylking
Copy link
Member

Requires OpenLiberty/ci.common#462

@cherylking cherylking merged commit 53cf892 into OpenLiberty:main Nov 13, 2024
12 checks passed
@cherylking cherylking mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherylking cherylking cherylking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arunvenmany-ibm @cherylking